[BOLT][Instrumentation]correct profile data handling for direct function calls #136231
Conversation
dinyy
requested review from
aaupov,
ayermolo,
dcci,
maksfb,
rafaelauler and
yota9
as code owners
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-bolt Author: None (dinyy) ChangesThis PR fixes an issue where the basic instrumentation test was failing for RISCV targets. The generated branch profile did not match the expected output in bolt/test/runtime/RISCV/basic-instrumentation.s > 1 __do_global_dtors_aux/1 8 1 __do_global_dtors_aux/1 a 0 1 After the fix, the output now correctly shows all expected branch transitions: > 1 _start 0 1 load_gp/1 0 0 1 Full diff: https://github.com/llvm/llvm-project/pull/136231.diff 1 Files Affected:
diff --git a/bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp b/bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp
index 0e27d29019e95..b6976e606cf51 100644
--- a/bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp
+++ b/bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp
@@ -322,6 +322,8 @@ class RISCVMCPlusBuilder : public MCPlusBuilder {
default:
return false;
case RISCV::C_J:
+ case RISCV::PseudoCALL:
+ case RISCV::PseudoTAIL:
OpNum = 0;
return true;
case RISCV::AUIPC:
|
3 participants
This PR fixes an issue where the basic instrumentation test was failing for RISCV targets. The generated branch profile did not match the expected output in bolt/test/runtime/RISCV/basic-instrumentation.s
Before the fix, the output contained incomplete branch information and missing critical transitions:
After the fix, the output now correctly shows all expected branch transitions: